Skip to content

Make Contour.jl compatible with GLVisualize #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 31, 2016

Conversation

SimonDanisch
Copy link
Member

It already would work out of the box, but it's nicer if Contour.jl supports Float32 and FixedSizeArrays/GeometryTypes for points.
A little teaser from GLVisualize next2 branch:

image

Generated with this code:
https://github.com/JuliaGL/GLVisualize.jl/blob/next2/examples/contours.jl
Note, that FixedSizeArrays needs Julia 0.4 ...

Best,
Simon

@codecov-io
Copy link

Current coverage is 96.74%

Branch #27 has no coverage reports uploaded yet.

No diff could be generated. No reports for master found.

Powered by Codecov. Updated on successful CI builds.

@darwindarak
Copy link
Collaborator

That looks awesome! Thanks!

darwindarak added a commit that referenced this pull request Jan 31, 2016
Make Contour.jl compatible with GLVisualize
@darwindarak darwindarak merged commit bdabbcd into JuliaGeometry:master Jan 31, 2016
@tomasaschan
Copy link
Contributor

Nice, thanks!

Since this deprecates support for 0.3, we should carefully test what the latest commit that works on 0.3 is and tag a release there, before tagging a new release that includes this.

@tomasaschan
Copy link
Contributor

By the way, @SimonDanisch: You're the first user outside of Gadfly (and myself for a small part of my master's thesis) that I know of that uses this library. What do you think of the API? Was it easy to work with?

@SimonDanisch
Copy link
Member Author

I think it's pretty nice!
By the way, I'm working on ways to represent the xyz points uniformly independant from the memory layout the user prefers.... This way it would be possible to allow the user more easily to switch between (x::Range, y::Range, z::Matrix), (x::Matrix, y::Matrix, z::Matrix), (xyz::Matrix{Point3}), while only writing one version of the algorithm.
I'm not sure how well this might work for your algorithm, but this is the PR you should watch out for: JuliaArrays/StructsOfArrays.jl#3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants